Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynfilter): left table with singleton dist panic bug #15406

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Mar 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Dynamic filter executor didn't handle left table with singleton distribution previously, this PR fixes it. Fixes #15302.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc requested review from st1page and kwannoel March 4, 2024 07:48
@github-actions github-actions bot added the type/fix Bug fix label Mar 4, 2024
@st1page
Copy link
Contributor

st1page commented Mar 4, 2024

add an e2e test?

Signed-off-by: Richard Chien <[email protected]>
@stdrc
Copy link
Member Author

stdrc commented Mar 4, 2024

add an e2e test?

OK

@stdrc stdrc enabled auto-merge March 4, 2024 08:27
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 7162071 Mar 5, 2024
26 of 27 checks passed
@stdrc stdrc deleted the rc/fix-dynfilter branch March 5, 2024 08:16
stdrc added a commit that referenced this pull request Mar 5, 2024
stdrc added a commit that referenced this pull request Mar 5, 2024
stdrc added a commit that referenced this pull request Mar 5, 2024
stdrc added a commit that referenced this pull request Mar 5, 2024
stdrc added a commit that referenced this pull request Mar 5, 2024
…15406) to branch release-1.7.0-standalone (#15467)

Signed-off-by: Richard Chien <[email protected]>
lmatz pushed a commit that referenced this pull request Mar 7, 2024
…15406) to branch release-1.7 (#15466)

Signed-off-by: Richard Chien <[email protected]>
Co-authored-by: stonepage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dyn filter can not handle the singleton input.
2 participants